Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vulkan] Fix some vulkan stuff #3198

Merged
merged 3 commits into from
Oct 15, 2021
Merged

[vulkan] Fix some vulkan stuff #3198

merged 3 commits into from
Oct 15, 2021

Conversation

AmesingFlank
Copy link
Collaborator

@AmesingFlank AmesingFlank commented Oct 14, 2021 •
edited
Loading

related issue = #3178
This PR fixes 3 things:

  1. During ti.sync(), submit the cmd list if it hasn't been submitted.
  2. Write the cell size back to SNode during struct compilation
  3. Fix a type error in float_atomic. This fixes test_reduction.

@netlify
Copy link

netlify bot commented Oct 14, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: ce959e9

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6168cf017d1a000007301ccd

bobcao3
bobcao3 approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm a bit confused on the test reduction situation. I have spotted some type errors on the uint side but my fix can't seem to fix the problem @k-ye observed. He said the tests fail on u32 types. (I can't repro any one of the case so I'm chasing it blind)

@AmesingFlank
Copy link
Collaborator Author

Looks good, but I'm a bit confused on the test reduction situation. I have spotted some type errors on the uint side but my fix can't seem to fix the problem @k-ye observed. He said the tests fail on u32 types. (I can't repro any one of the case so I'm chasing it blind)

Huh, Interesting. I observed failures for f32 only.
It's also confusing that CI passed for #3164 as well. How did we discover the test_reduction failure in the first place?

g1n0st
g1n0st approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@g1n0st g1n0st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My bad : (

k-ye
k-ye reviewed Oct 15, 2021
View reviewed changes
taichi/backends/vulkan/snode_struct_compiler.cpp
@@ -43,6 +43,8 @@ class StructCompiler {
cell_stride * sn_desc.cells_per_container_pot();
}

sn->cell_size_bytes = sn_desc.cell_stride;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does VK backend actually use this? That said, we should make this part backend-neutral.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using cell size bytes for computing SNode Device ptr in ggui.

k-ye
k-ye approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@k-ye k-ye merged commit 8ef84b1 into taichi-dev:master Oct 15, 2021
@k-ye
Copy link
Member

k-ye commented Oct 15, 2021

Fixes #3178 by #3198, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g1n0st g1n0st g1n0st approved these changes

@bobcao3 bobcao3 bobcao3 approved these changes

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmesingFlank @k-ye @bobcao3 @g1n0st